Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the quickstart performance benchmarking setup so that the GitHub Actions workflow can successfully build and benchmark Timefold quickstarts (including enterprise) and so nightly automation also triggers the quickstart perf workflow.
Changes:
- Force single-threaded solver execution during quickstart benchmarking by setting
quarkus.timefold.solver.move-thread-count=NONE. - Fix/modernize the quickstart perf workflow to use
TimefoldAI/timefold-quickstarts(development branch), build with theenterpriseMaven profile, and buildtimefold-solver-enterprise. - Extend the nightly workflow to also queue the quickstart perf workflow after the score director perf workflow.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
benchmark-quickstarts.py |
Adds a JVM system property to disable move threading for more stable perf measurements. |
.github/workflows/performance_quickstarts.yml |
Switches to the new quickstarts repo/branch, adds enterprise build steps, and wires enterprise license into benchmark runs. |
.github/workflows/nightly_performance.yml |
Triggers quickstart perf workflow as part of nightly performance automation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+88
to
+100
| - name: Checkout timefold-solver-enterprise | ||
| uses: actions/checkout@v4 | ||
| with: | ||
| repository: TimefoldAI/timefold-solver-enterprise | ||
| ref: ${{ github.event.inputs.baseline }} | ||
| token: ${{ secrets.BENCHMARK_PUBLISH_TOKEN }} | ||
| path: ./timefold-solver-enterprise | ||
|
|
||
| - name: Quickly build timefold-solver-enterprise | ||
| working-directory: ./timefold-solver-enterprise | ||
| shell: bash | ||
| run: ./mvnw -B -Dquickly clean install | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The job finally works, now that I've been able to debug it.